Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Export getRouter() selector #428

Merged
merged 1 commit into from Aug 29, 2020

Conversation

devrelm
Copy link
Contributor

@devrelm devrelm commented Jun 16, 2020

Fixes #427:

The types file lists getRouter() as being available:

export function getRouter<S extends RouterRootState<LS>, LS = LocationState>(state: S): RouterState<LS>;

It's returned from createSelectors():

return {
getLocation,
getAction,
getRouter,
getSearch,
getHash,
createMatchSelector,
}

but is not actually exported from the package:

export const { getLocation, getAction, getHash, getSearch, createMatchSelector } = /*#__PURE__*/ createSelectors(plainStructure)

export const { getLocation, getAction, getHash, getSearch, createMatchSelector } = /*#__PURE__*/ createSelectors(immutableStructure)

export const { getLocation, getAction, getHash, getSearch, createMatchSelector } = /*#__PURE__*/ createSelectors(immutableStructure)

This PR rectifies this by adding getRouter to the export in each of the 3 files above.

@devrelm devrelm changed the title Export getRouter() selector Fix: Export getRouter() selector Jun 16, 2020
@supasate
Copy link
Owner

LGTM. Sorry for delayed response.

@supasate supasate merged commit 70a7511 into supasate:master Aug 29, 2020
@devrelm devrelm deleted the devrelm/export-getRouter branch August 29, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getRouter() selector is not exported
2 participants