Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate container image labels #4926

Merged
merged 18 commits into from
Dec 7, 2023
Merged

Validate container image labels #4926

merged 18 commits into from
Dec 7, 2023

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Nov 30, 2023 •
edited
Loading

Fixes #4895

Proposed Changes

  1. Enable container image labels validation.
  2. Fix a bug that caused the wrong revision to be set when building container images in the context of a pull request.
  3. Remove obsolete scripts and docs.
  4. Enable Docker buildx on GitHub Actions as we do locally.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

BEGIN_COMMIT_OVERRIDE
ci: validate container image labels (#4926)
END_COMMIT_OVERRIDE

@ferrarimarco ferrarimarco added the infrastructure related to project structure and maintenance label Nov 30, 2023
@ferrarimarco ferrarimarco self-assigned this Nov 30, 2023
@ferrarimarco ferrarimarco marked this pull request as draft November 30, 2023 21:09
@ferrarimarco ferrarimarco changed the title Validate labels and avoid busting the cache Validate labels and avoid invalidating the cache Nov 30, 2023
@ferrarimarco ferrarimarco changed the title Validate labels and avoid invalidating the cache Validate container image labels Dec 1, 2023
@ferrarimarco ferrarimarco marked this pull request as ready for review December 1, 2023 10:37
@ferrarimarco ferrarimarco mentioned this pull request Dec 1, 2023
Merged
3 tasks
@ferrarimarco ferrarimarco added the O: backlog 🤖 Backlog, stale ignores this label label Dec 1, 2023
zkoppert
zkoppert reviewed Dec 2, 2023
View reviewed changes
Makefile Show resolved Hide resolved
zkoppert
zkoppert previously approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ferrarimarco ferrarimarco added this pull request to the merge queue Dec 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2023
@ferrarimarco ferrarimarco added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 9869638 Dec 7, 2023
3 checks passed
@ferrarimarco ferrarimarco deleted the test-labels branch December 7, 2023 14:43
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

@admiralAwkbar admiralAwkbar Awaiting requested review from admiralAwkbar

@lindluni lindluni Awaiting requested review from lindluni

@nemchik nemchik Awaiting requested review from nemchik

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

@GaboFDC GaboFDC Awaiting requested review from GaboFDC

Assignees

@ferrarimarco ferrarimarco

Labels
infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add back container image labels tests and remove obsolete scripts
2 participants
@ferrarimarco @zkoppert