Don't write colors and logs on disk if not necessary #4934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
CREATE_LOG_FILE
is not set totrue
. This resulted in about 50% increase in performance in our CI builds. For example, compare the results of this build against this.cat
to copy data.Example log line in the log file before this change:
�[0m2023-12-04 10:06:17 �[0;34m[INFO]�[0m Linting [JSCPD] files...�[0m
After:
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large, fundamental change.automation
,bug
,documentation
,enhancement
,infrastructure
.BEGIN_COMMIT_OVERRIDE
feat: don't write colors and logs on disk if not necessary (#4934)
END_COMMIT_OVERRIDE