-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't forcefully validate Git repos if not needed #4953
Conversation
When I look at the commit for this it only appears to include the code for "2. Add a workflow step to catch this issue." |
Yep. As I explained in #4952, I'd like to see a failing workflow, that we'll fix by committing the change you suggested. :) This helps us validate the fix, and may help catching this or similar issues in the future. |
Gotcha, thanks. |
3a0c27f
to
3c6a260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Fixes #4952
Proposed Changes
USE_FIND_ALGORITHM=true
.git safe.directory
after we setGITHUB_WORKSPACE
, and not before becauseGITHUB_WORKSPACE
might be initialized when running locally.VALIDATE_ALL_CODEBASE
because we need a valid Git repository and references both whenVALIDATE_ALL_CODEBASE=true
and whenVALIDATE_ALL_CODEBASE=false
.USE_FIND_ALGORITHM == false
, not whenUSE_FIND_ALGORITHM != false
.GITHUB_SHA
when running locally and whenUSE_FIND_ALGORITHM == false
.DEFAULT_BRANCH
when running tests.Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large, fundamental change.automation
,bug
,documentation
,enhancement
,infrastructure
.BEGIN_COMMIT_OVERRIDE
fix: don't forcefully validate Git repos if not needed (#4953)
END_COMMIT_OVERRIDE