Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication in CI and CD workflows #4982

Merged
merged 6 commits into from
Dec 12, 2023

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Dec 11, 2023

Proposed Changes

  1. Define a lint-codebase Make target to run super-linter against the current codebase.
  2. Define a test-linters Make target to run the super-linter test suite.
  3. Add these new targets to the test target.
  4. Remove the related build steps from the CI and CD workflows because we call make test there anyway.
  5. Fix list numbers in README.
  6. Support loading GITHUB_TOKEN from a file.

This is a step in the direction of reducing duplications in workflows.

Readiness Checklist

Author/Contributor

  • I included all the needed documentation for this change.
  • I provided the necessary tests.

Reviewing Maintainer

  • Label as breaking if this is a large, fundamental change.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

BEGIN_COMMIT_OVERRIDE
ci: reduce duplication in CI and CD workflows (#4982)
END_COMMIT_OVERRIDE

@ferrarimarco ferrarimarco added the infrastructure related to project structure and maintenance label Dec 11, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 11, 2023
@ferrarimarco ferrarimarco marked this pull request as ready for review December 11, 2023 20:45
@zkoppert
Copy link
Contributor

This pull request looks good. I tried testing out the make test locally by following the instructions here and got an error when checking the image.created tag. To be clear, I don't think this pull request has caused this issue but we should probably fix while we are in here. Does this pass for you @ferrarimarco or should we updated the BUILD_DATE here?

[ERROR] Invalid container image label: org.opencontainers.image.created: 2023-10-17T17:00:53Z. Expected: 2023-10-17T16:19:11Z

@ferrarimarco
Copy link
Collaborator Author

Yes, I'll have a look at this. Thanks for the review!

@ferrarimarco
Copy link
Collaborator Author

ferrarimarco commented Dec 12, 2023

@zkoppert I think I fixed it. Can you please take another look? Thanks!

PS: the local build passes, and the command you linked to works after the fix.

Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Great work! Thank you @ferrarimarco!

@ferrarimarco ferrarimarco added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit ac4b767 Dec 12, 2023
3 checks passed
@ferrarimarco ferrarimarco deleted the reduce-duplication-workflows branch December 12, 2023 19:19
ferrarimarco added a commit that referenced this pull request Dec 12, 2023
* main:
  Reduce duplication in CI and CD workflows (#4982)
  Move instructions from the wiki to docs (#4957)
  Update documentation (#4981)
ferrarimarco added a commit that referenced this pull request Dec 12, 2023
* main:
  Group log output on GitHub Actions (#4961)
  Reduce duplication in CI and CD workflows (#4982)
  Move instructions from the wiki to docs (#4957)
  Update documentation (#4981)
  Bump com.puppycrawl.tools:checkstyle in /dependencies/checkstyle (#4966)
  Bump isort from 5.12.0 to 5.13.0 in /dependencies/python (#4967)
  Bump pylint from 3.0.2 to 3.0.3 in /dependencies/python (#4968)
  Bump cfn-lint from 0.83.3 to 0.83.4 in /dependencies/python (#4969)
  Bump npm-groovy-lint from 13.0.0 to 13.0.2 in /dependencies (#4970)
  Bump typescript from 5.3.2 to 5.3.3 in /dependencies (#4972)
  Bump next from 14.0.3 to 14.0.4 in /dependencies (#4973)
  Bump react-redux from 9.0.1 to 9.0.3 in /dependencies (#4974)
  Bump renovate from 37.83.5 to 37.89.7 in /dependencies (#4975)
  Bump prettier from 3.1.0 to 3.1.1 in /dependencies (#4976)
  Bump stylelint-scss from 5.3.1 to 5.3.2 in /dependencies (#4977)
  Bump golang from 1.21.4-alpine to 1.21.5-alpine (#4978)
  Bump actions/stale from 8 to 9 (#4980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure related to project structure and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants