Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify lintr installation #4994

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Simplify lintr installation #4994

merged 1 commit into from
Dec 21, 2023

Conversation

ferrarimarco
Copy link
Collaborator

Fixes #4992

Proposed Changes

  1. Fail if the installation of a R package fails.
  2. Install the remotes package once during the image build, and not when we scan files at runtime.
  3. Reuse the default R library directory instead of moving it to /home/r-library/ and installing modules there.

Readiness Checklist

Author/Contributor

  • I included all the needed documentation for this change.
  • I provided the necessary tests.

Reviewing Maintainer

  • Label as breaking if this is a large, fundamental change.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added the bug Something isn't working label Dec 15, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 15, 2023
@ferrarimarco ferrarimarco added the O: backlog 🤖 Backlog, stale ignores this label label Dec 15, 2023
- Fail if the installation of a R package fails.
- Install the remotes package once during the image build, and not when we scan
  files at runtime.
- Reuse the default R library directory instead of moving it to /home/r-library
@ferrarimarco ferrarimarco merged commit 60983d3 into main Dec 21, 2023
8 checks passed
@ferrarimarco ferrarimarco deleted the simplify-r-install branch December 21, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed R package installation didn't stop the container image build
1 participant