Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure commitlint #5014

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Configure commitlint #5014

merged 1 commit into from
Dec 19, 2023

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Dec 18, 2023

Proposed Changes

  • Enable commitlint to check if commits adhere to the
    conventialcommits.org spec.
  • Update the the pull request template to point to the conventional
    commit spec.
  • Update the dependabot configuration to add the "build(...)" prefix to
    commits.

Related to #4947

After this is merged, configure the Lint commit workflow the as a required check for the default branch.

Readiness Checklist

Author/Contributor

  • I included all the needed documentation for this change.
  • I provided the necessary tests.

Reviewing Maintainer

  • Label as breaking if this is a large, fundamental change.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added the automation related to helping the project operate more efficiently label Dec 18, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 18, 2023
@ferrarimarco ferrarimarco marked this pull request as ready for review December 18, 2023 15:08
@ferrarimarco ferrarimarco changed the title Configure commitlint ci: Configure commitlint Dec 18, 2023
@ferrarimarco ferrarimarco force-pushed the lint-commits branch 3 times, most recently from 0b4d5a9 to 19b9e41 Compare December 18, 2023 15:14
@ferrarimarco ferrarimarco changed the title ci: Configure commitlint Configure commitlint Dec 18, 2023
@ferrarimarco
Copy link
Collaborator Author

ferrarimarco commented Dec 18, 2023

@zkoppert If I got the commitlint configuration right, this PR should pass the required checks when it will be added to the merge queue because this repository is configured to use the default message when merging with a squash commit (the commit title and the commit message, because it contains a single commit, source).

@ferrarimarco ferrarimarco force-pushed the lint-commits branch 2 times, most recently from 50ab878 to 84f26e3 Compare December 18, 2023 18:13
@ferrarimarco ferrarimarco mentioned this pull request Dec 18, 2023
6 tasks
@ferrarimarco ferrarimarco marked this pull request as draft December 19, 2023 14:12
- Check if the PR contains a single commit, and fail otherwise.
- Enable commitlint to check if commits adhere to the
  conventialcommits.org spec.
- Update the the pull request template to point to the conventional
  commit spec.
- Update the dependabot configuration to add the "build(...)" prefix to
  commits.
@ferrarimarco ferrarimarco marked this pull request as ready for review December 19, 2023 14:46
@ferrarimarco ferrarimarco merged commit 9db632f into main Dec 19, 2023
5 checks passed
@ferrarimarco ferrarimarco deleted the lint-commits branch December 19, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation related to helping the project operate more efficiently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant