Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file list diff when looking for changes #5044

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Dec 22, 2023

Fixes #1167

Proposed Changes

  • Fix the file diff function on push events.
  • Add several tests for GenerateFileDiff

Readiness Checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Dec 22, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 22, 2023
@ferrarimarco ferrarimarco force-pushed the test-file-find branch 2 times, most recently from 089634b to 75bd167 Compare December 23, 2023 17:51
- Fix the file diff function on push events.
- Implement a test for the file diff function
@ferrarimarco ferrarimarco changed the title Test file find Fix file list diff when looking for changes Dec 23, 2023
@ferrarimarco ferrarimarco marked this pull request as ready for review December 23, 2023 18:00
@ferrarimarco ferrarimarco merged commit b214a59 into main Dec 23, 2023
6 checks passed
@ferrarimarco ferrarimarco deleted the test-file-find branch December 23, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Super-linter algorithm for finding changed files is broken
1 participant