Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail when validating as expected #5076

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Fail when validating as expected #5076

merged 1 commit into from
Dec 30, 2023

Conversation

ferrarimarco
Copy link
Collaborator

Proposed Changes

  • Fail when USE_FIND_ALGORITHM is true and VALIDATE_ALL_CODEBASE is false as expected.

Readiness Checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • If this is a breaking change, write upgrade instructions in the upgrade guide.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco
fix: fail when validating as expected
137be5f 
Fail when USE_FIND_ALGORITHM is true and VALIDATE_ALL_CODEBASE is false
as expected.
@ferrarimarco ferrarimarco added the bug Something isn't working label Dec 30, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 30, 2023
@ferrarimarco ferrarimarco changed the title fix: fail when validating as expected Fail when validating as expected Dec 30, 2023
@ferrarimarco ferrarimarco merged commit ededa44 into main Dec 30, 2023
6 checks passed
@ferrarimarco ferrarimarco deleted the fix-fail branch December 30, 2023 22:02
@github-actions github-actions bot mentioned this pull request Dec 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert is a code owner

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

Assignees

@ferrarimarco ferrarimarco

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ferrarimarco