Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GITHUB_BEFORE_SHA initialization on push events #5096

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix GITHUB_BEFORE_SHA initialization on push events #5096

merged 1 commit into from
Jan 4, 2024

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Jan 4, 2024 •
edited
Loading

Proposed Changes

  • Fix GITHUB_BEFORE_SHA initialization on push events by setting the
    correct key.
  • Add an additional check against setting GITHUB_BEFORE_SHA to null.
  • Run the CI workflow on push events to trigger required status checks
    when using the merge queue.

Readiness Checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • If this is a breaking change, write upgrade instructions in the upgrade guide.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added automation related to helping the project operate more efficiently O: backlog 🤖 Backlog, stale ignores this label labels Jan 4, 2024
@ferrarimarco ferrarimarco self-assigned this Jan 4, 2024
@ferrarimarco ferrarimarco changed the title ci: run the ci workflow on pushes Run the ci workflow on pushes Jan 4, 2024
@ferrarimarco ferrarimarco force-pushed the ci-on-push branch 3 times, most recently from 6c5af56 to f6af2d9 Compare January 4, 2024 15:05
@ferrarimarco ferrarimarco changed the title Run the ci workflow on pushes Fix GITHUB_BEFORE_SHA initialization on push event Jan 4, 2024
@ferrarimarco ferrarimarco changed the title Fix GITHUB_BEFORE_SHA initialization on push event Fix GITHUB_BEFORE_SHA initialization on push events Jan 4, 2024
@ferrarimarco ferrarimarco force-pushed the ci-on-push branch 5 times, most recently from 73f5ac2 to 4b040a0 Compare January 4, 2024 21:26
@ferrarimarco
fix: fix GITHUB_BEFORE_SHA diff on push events
45d3bb6 
- Fix GITHUB_BEFORE_SHA initialization on push events by setting the
  correct key.
- Add an additional check against setting GITHUB_BEFORE_SHA to null.
- Run the CI workflow on push events to trigger required status checks
  when using the merge queue.
@ferrarimarco ferrarimarco added bug Something isn't working and removed automation related to helping the project operate more efficiently labels Jan 4, 2024
@ferrarimarco ferrarimarco merged commit 1d5ed2c into main Jan 4, 2024
9 checks passed
@ferrarimarco ferrarimarco deleted the ci-on-push branch January 4, 2024 21:54
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
Merged
@ferrarimarco ferrarimarco mentioned this pull request Jan 4, 2024
Merged
8 tasks
@tremblaysimon tremblaysimon mentioned this pull request Feb 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert is a code owner

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

Assignees

@ferrarimarco ferrarimarco

Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ferrarimarco