Handle log messages in CheckFileType #5117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrarimarco
added
bug
ferrarimarco
changed the title
ferrarimarco
force-pushed
the
fix-detect-files
branch
from
a823b1a
to
85a979c
Compare
- Honor SUPPRESS_FILE_TYPE_WARN when printing messages in the CheckFileType function. - Reduce duplication when handling log messages in the CheckFileType function. - Don't add files to the array of files to lint with JSCPD because we lint the whole codebase with JSCPD anyway.
ferrarimarco
force-pushed
the
fix-detect-files
branch
from
85a979c
to
452f2e9
Compare
|
@zkoppert going ahead with this one, it's a fairly simple change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Readiness checklist
In order to have this pull request merged, complete the following tasks.
Pull request author tasks
I added the
Fix #ISSUE_NUMBERlabel to the description of the pull request.Super-linter maintainer tasks
breakingif this change breaks compatibility with the previous released version.automation,bug,documentation,enhancement,infrastructure.