Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run versions command in the slim stage #5127

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Run versions command in the slim stage #5127

merged 1 commit into from
Jan 11, 2024

Conversation

ferrarimarco
Copy link
Collaborator

Proposed changes

Move the invocation of the command to build the linter versions file in the slim stage because we run it again in the standard stage anyway, so there's no need for the standard stage to wait for this command to run.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco
build: run versions command in the slim stage
76f6822 
Move the invocation of the command to build the linter versions file in
the slim stage because we run it again in the standard stage anyway, so
there's no need for the standard stage to wait for this command to run.
@ferrarimarco ferrarimarco added automation related to helping the project operate more efficiently O: backlog 🤖 Backlog, stale ignores this label labels Jan 11, 2024
@ferrarimarco ferrarimarco self-assigned this Jan 11, 2024
@ferrarimarco ferrarimarco added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit d5da0ce Jan 11, 2024
10 checks passed
@ferrarimarco ferrarimarco deleted the docker-build-versions branch January 11, 2024 20:46
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

Assignees

@ferrarimarco ferrarimarco

Labels
automation related to helping the project operate more efficiently O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ferrarimarco @zkoppert