Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify updateSSL #5130

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Simplify updateSSL #5130

merged 1 commit into from
Jan 30, 2024

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Jan 11, 2024

Proposed changes

Run command directly instead of checking their exit code afterwards.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label labels Jan 11, 2024
@ferrarimarco ferrarimarco self-assigned this Jan 11, 2024
@ferrarimarco ferrarimarco mentioned this pull request Jan 11, 2024
8 tasks
@ferrarimarco ferrarimarco force-pushed the simplify-ssh-ssl branch 3 times, most recently from c8fed44 to 4a67267 Compare January 15, 2024 17:31
Run command directly instead of checking their exit code afterwards.
@ferrarimarco ferrarimarco merged commit 9bab4a9 into main Jan 30, 2024
9 checks passed
@ferrarimarco ferrarimarco deleted the simplify-ssh-ssl branch January 30, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant