Move linter versions logic outside runtime #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrarimarco
added
infrastructure
ferrarimarco
force-pushed
the
parallel-batched
branch
3 times, most recently
from
68d0d78
to
ed30871
Compare
ferrarimarco
force-pushed
the
linter-versions
branch
from
fd674b2
to
7e8222c
Compare
ferrarimarco
force-pushed
the
linter-versions
branch
2 times, most recently
from
6126cac
to
e1a20a5
Compare
Move the logic to build the linter versions file outside the main runtime. There's no need to include it there because it's used only when building the image. Move the list of linters by name in linterVersions.sh because we don't need it in any other place.
ferrarimarco
force-pushed
the
linter-versions
branch
from
e1a20a5
to
d12fbb1
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Move the logic to build the linter versions file outside the main
runtime. There's no need to include it there because it's used only when
building the image.
Move the list of linters by name in linterVersions.sh because we don't
need it in any other place.
Readiness checklist
In order to have this pull request merged, complete the following tasks.
Pull request author tasks
I added the
Fix #ISSUE_NUMBERlabel to the description of the pull request.Super-linter maintainer tasks
breakingif this change breaks compatibility with the previous released version.automation,bug,documentation,enhancement,infrastructure.