Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on errors when installing chktex #5214

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

ferrarimarco
Copy link
Collaborator

Proposed changes

Refactor the chktex installation scripts because lists of commands don't fail if one of them exits with an error, even if set -e (errexit) is set.

See the Bash reference manual, section 4.3.1 'The Set Builtin'.

Fix #5122

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

Refactor the chktex installation scripts because lists of commands don't
fail if one of them exits with an error, even if set -e (errexit) is
set.

See the Bash reference manual, section 4.3.1 'The Set Builtin'.
@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label labels Feb 1, 2024
@ferrarimarco ferrarimarco self-assigned this Feb 1, 2024
@ferrarimarco ferrarimarco changed the title build: fail on errors when installing chktex Fail on errors when installing chktex Feb 1, 2024
@ferrarimarco ferrarimarco merged commit 92e9cb3 into main Feb 5, 2024
9 checks passed
@ferrarimarco ferrarimarco deleted the fail-on-chktex-errors branch February 5, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chktex installation script didn't fail on transitory network error
1 participant