Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize GitHub domain variable #5216

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Initialize GitHub domain variable #5216

merged 1 commit into from
Feb 9, 2024

Conversation

ferrarimarco
Copy link
Collaborator

Proposed changes

  • Initialize GITHUB_DOMAIN as documented in the README
  • Configure other URLs according to GITHUB_DOMAIN
  • Automatically fetch SSH key fingerprints for GITHUB_DOMAIN

Close #4825

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Feb 1, 2024
@ferrarimarco ferrarimarco force-pushed the fetch-fingerprint branch 2 times, most recently from 59202d3 to 5b5d7f6 Compare February 2, 2024 15:25
@ferrarimarco ferrarimarco marked this pull request as draft February 2, 2024 23:07
- Initialize GITHUB_DOMAIN as documented in the README
- Configure other URLs according to GITHUB_DOMAIN
- Automatically fetch SSH key fingerprints for GITHUB_DOMAINS
@ferrarimarco ferrarimarco marked this pull request as ready for review February 6, 2024 15:05
@ferrarimarco ferrarimarco added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit 6fd6830 Feb 9, 2024
9 checks passed
@ferrarimarco ferrarimarco deleted the fetch-fingerprint branch February 9, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using SSH_KEY produces "Could not verify github.com key"
2 participants