Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add unnecessary empty lines #5221

Closed
wants to merge 0 commits into from
Closed

Conversation

ferrarimarco
Copy link
Collaborator

Proposed changes

Strip the final newline from stout and stderr so that we don't add the empty line twice when logging.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Feb 2, 2024
@ferrarimarco ferrarimarco self-assigned this Feb 2, 2024
@ferrarimarco ferrarimarco deleted the avoid-empty-lines branch February 5, 2024 11:09
@ferrarimarco
Copy link
Collaborator Author

This was merged, but due to this GitHub incident, the merge operation stopped and didn't recover. When I rebased, the PR was marked as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant