Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mypy cache directory #5240

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Create mypy cache directory #5240

merged 1 commit into from
Feb 6, 2024

Conversation

ferrarimarco
Copy link
Collaborator

Proposed changes

MyPy expects the cache directory to be there. We now remove it after each super-linter run to avoid leftovers, so we need to create it before running MyPy.

See python/mypy#10768
and python/mypy#10863

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Feb 6, 2024
@ferrarimarco ferrarimarco self-assigned this Feb 6, 2024
MyPy expects the cache directory to be there. We now remove it after
each super-linter run to avoid leftovers, so we need to create it before
running MyPy.

See python/mypy#10768
and python/mypy#10863
@ferrarimarco ferrarimarco merged commit 38edbe5 into main Feb 6, 2024
9 checks passed
@ferrarimarco ferrarimarco deleted the fix-mypy branch February 6, 2024 14:53
@wolf-michael-bolle
Copy link

wolf-michael-bolle commented Feb 8, 2024

This bug only happens in certain scenarios when multiple Python files are linted but not in all cases that involve multiple Python files. In my case, it all revolved around a single module with utilities in an admittedly pointless subdirectory. I moved the file and gave it a less generic name which got it to work. Still, with super-linter 5.7.2, this did not happen.

@ferrarimarco
Copy link
Collaborator Author

Yeah, this was probably caused by #5210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants