Show error output when info is disabled #5251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrarimarco
added
enhancement
ferrarimarco
force-pushed
the
error-output
branch
from
ddd9a70
to
3df13fb
Compare
1 task
ferrarimarco
force-pushed
the
error-output
branch
from
3df13fb
to
45c2f4f
Compare
Hanse00
previously approved these changes
Feb 10, 2024
ferrarimarco
force-pushed
the
error-output
branch
from
45c2f4f
to
5db6a0d
Compare
In case of linting errors, print stdout and stderr (if present) at the ERROR level if users set LOG_LEVEL to NOTICE to avoid failures without any explanation.
ferrarimarco
force-pushed
the
error-output
branch
from
5db6a0d
to
4049268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In case of linting errors, print stdout and stderr (if present) at the ERROR level if users set LOG_LEVEL to NOTICE to avoid failures without any explanation.
Close #5218
Worth waiting for #5249 before merging this one, so we can benefit from the test script enhancements implemented in that PR.
Readiness checklist
In order to have this pull request merged, complete the following tasks.
Pull request author tasks
I added the
Fix #ISSUE_NUMBERlabel to the description of the pull request.Super-linter maintainer tasks
breakingif this change breaks compatibility with the previous released version.automation,bug,documentation,enhancement,infrastructure.