-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding clang-format style configuration #5424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @umitbuyukulcay !
Thanks for this PR. A couple of small things to check.
Thanks for the fixes! One small thing left, and can you please squash the commits in a single one? After that, we should be good to go :) |
sure, but how can i squash published commits? or if you want i can open new PR with one single commit. |
Hi! No need to open a new PR. You can follow these instructions to squash commits: https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together. In your case, you want to squash these 4 commits into one, and keep the Thanks for your work on this! |
0f9e935
to
7693461
Compare
Proposed changes
Clang-Format is a widely-used code formatter. On this PR, "-style" flag added to the clang-format which let user to the format with custom style rules.
Close #5413
Readiness checklist
In order to have this pull request merged, complete the following tasks.
Pull request author tasks
I added the
Fix #ISSUE_NUMBER
label to the description of the pull request.Super-linter maintainer tasks
breaking
if this change breaks compatibility with the previous released version.automation
,bug
,documentation
,enhancement
,infrastructure
.