Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding clang-format style configuration #5424

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

umitbuyukulcay
Copy link
Contributor

@umitbuyukulcay umitbuyukulcay commented Mar 21, 2024

Proposed changes

Clang-Format is a widely-used code formatter. On this PR, "-style" flag added to the clang-format which let user to the format with custom style rules.

Close #5413

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco changed the title feat: adding clang-format style configuration Fix #5413 feat: adding clang-format style configuration Mar 22, 2024
@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label labels Mar 22, 2024
Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @umitbuyukulcay !

Thanks for this PR. A couple of small things to check.

lib/linter.sh Outdated Show resolved Hide resolved
TEMPLATES/.clang-format Outdated Show resolved Hide resolved
.github/linters/.clang-format Outdated Show resolved Hide resolved
TEMPLATES/.clang-format Outdated Show resolved Hide resolved
@ferrarimarco
Copy link
Collaborator

Thanks for the fixes! One small thing left, and can you please squash the commits in a single one?

After that, we should be good to go :)

@umitbuyukulcay
Copy link
Contributor Author

Thanks for the fixes! One small thing left, and can you please squash the commits in a single one?

After that, we should be good to go :)

sure, but how can i squash published commits? or if you want i can open new PR with one single commit.

@ferrarimarco
Copy link
Collaborator

Hi! No need to open a new PR.

You can follow these instructions to squash commits: https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together.

In your case, you want to squash these 4 commits into one, and keep the feat:... commit message.

Thanks for your work on this!

@ferrarimarco ferrarimarco merged commit 0ae4572 into super-linter:main Apr 11, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clang Format Config File
2 participants