Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set permissions in the README example #5452

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

mohamedhamdyamer
Copy link
Contributor

@mohamedhamdyamer mohamedhamdyamer commented Mar 26, 2024

adding:
permissions: read-all

This is to avoid failure of super-linter that is triggered by checkov.

checkov flags that the top-level permissions are set to "write-all" (default value). Accordingly, the action will fail with an error.

Proposed changes

Small addition to the yaml example as described above

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! A small thing to check.

README.md Outdated Show resolved Hide resolved
@mohamedhamdyamer
Copy link
Contributor Author

Hi Team,

Just updated the commit message to be shorter and compliant with Conventional Commits.

README.md Outdated Show resolved Hide resolved
@ferrarimarco ferrarimarco changed the title Update README.md - editing the yaml example Set permissions in the README example Apr 8, 2024
@ferrarimarco ferrarimarco added this pull request to the merge queue Apr 9, 2024
Merged via the queue into super-linter:main with commit 64d808d Apr 9, 2024
43 of 44 checks passed
@mohamedhamdyamer mohamedhamdyamer deleted the patch-1 branch April 15, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants