Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python Test Files #5502

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

Okabe-Junya
Copy link
Contributor

@Okabe-Junya Okabe-Junya commented Apr 10, 2024

Proposed changes

  • align python test files to ruff.

fix #5501

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@Okabe-Junya Okabe-Junya marked this pull request as ready for review April 10, 2024 18:17
Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Okabe-Junya !

Thanks for this PR.

A small thing to check, so we can run the rest of the CI jobs.

test/linters/python_isort/python_bad_1.py Outdated Show resolved Hide resolved
fix: revert python_isort/python_bad_1.py
@Okabe-Junya
Copy link
Contributor Author

Hi @ferrarimarco, thank you for your review!! And, sorry for my delay in response.

I checked your review comment and fixed it!! Please take a look again 💙 thanks!!

@ferrarimarco
Copy link
Collaborator

No worries, thanks for this work!

@ferrarimarco ferrarimarco added this pull request to the merge queue Apr 15, 2024
Merged via the queue into super-linter:main with commit ca2a416 Apr 15, 2024
43 of 44 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-5501 branch April 15, 2024 12:35
@Okabe-Junya
Copy link
Contributor Author

Thank you for your kind supports!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Python Test Files
2 participants