Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support GoReleaser #5505

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat: support GoReleaser #5505

merged 1 commit into from
Apr 15, 2024

Conversation

massongit
Copy link
Contributor

@massongit massongit commented Apr 13, 2024 •
edited

Proposed changes

Fix #5504

I add GoReleaser to validate .goreleaser.yaml.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@massongit massongit force-pushed the add_goreleaser branch 4 times, most recently from 6c3ef2f to 8e23aae Compare April 13, 2024 23:09
@massongit massongit changed the title Support GoReleaser feat: support GoReleaser Apr 13, 2024
@massongit massongit marked this pull request as ready for review April 14, 2024 07:58
ferrarimarco
ferrarimarco requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change in the README, and we are good to go! Thanks for this PR

README.md Outdated Show resolved Hide resolved
@ferrarimarco ferrarimarco added this pull request to the merge queue Apr 15, 2024
Merged via the queue into super-linter:main with commit 6924988 Apr 15, 2024
45 checks passed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Merged
@massongit massongit deleted the add_goreleaser branch April 15, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrarimarco ferrarimarco ferrarimarco approved these changes

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert is a code owner

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support goreleaser check
2 participants
@massongit @ferrarimarco