Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for POWERSHELL_CONFIG_FILE #5674

Merged
merged 1 commit into from
May 24, 2024

Conversation

x-delfino
Copy link
Contributor

@x-delfino x-delfino commented May 20, 2024

Proposed changes

Support POWERSHELL_CONFIG_FILE to specify custom file name for PSScriptAnalyzer config

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @x-delfino !

Thanks for this PR!

@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label labels May 20, 2024
@ferrarimarco ferrarimarco added this to the 6.6.0 milestone May 21, 2024
@x-delfino
Copy link
Contributor Author

Just thinking - is there any reason not to add this for all linters that support a config file? Should be a fairly straightforward change and can leave the current values as defaults

@ferrarimarco
Copy link
Collaborator

There isn't any reason for not doing this. Feel free to send follow-up PRs to address that. We'll happily review them.

Thanks a lot!

@ferrarimarco ferrarimarco added this pull request to the merge queue May 24, 2024
Merged via the queue into super-linter:main with commit 3f56c89 May 24, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants