Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't skip processing ansible_directory pwd #5790

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Jun 19, 2024

Proposed changes

Don't skip processing the current item (FILE) before we give BuildFileArrays the chance to process it as an item to eventually add to the list of directories to lint with ansible-lint.

Fix #5789

Other related changes

  • Add a new make target to open a shell in a Super-linter container.
  • Use a fixed path for FILE_ARRAYS_DIRECTORY_PATH so we can verify its contents in tests
  • Remove redundant ValidateBooleanVariable in buildFileList because we already check those variables in valudation.
  • Move Ansible directory detection to a function so we can reuse it.
  • Add missing exports for global configuration variables.
  • Remove unused LOG_XXXX variables from tests. These should have been deleted when we moved log variables to log.sh

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches with the version that release-please proposes.

@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Jun 19, 2024
@ferrarimarco ferrarimarco added this to the 6.7.0 milestone Jun 19, 2024
@ferrarimarco ferrarimarco force-pushed the fix-ansible-lint-pwd branch 5 times, most recently from 49fda05 to 86f26de Compare June 19, 2024 13:47
Don't skip processing the current item (FILE) before we give
BuildFileArrays the chance to process it as an item to eventually add to
the list of directories to lint with ansible-lint.

Fix #5789

Other related changes

- Add a new make target to open a shell in a Super-linter container.
- Use a fixed path for FILE_ARRAYS_DIRECTORY_PATH so we can verify its
  contents in tests
- Remove redundant ValidateBooleanVariable in buildFileList because we
  already check those variables in valudation.
- Move Ansible directory detection to a function so we can reuse it.
- Add missing exports for global configuration variables.
- Remove unused LOG_XXXX variables from tests. These should have been
  deleted when we moved log variables to log.sh
Makefile Show resolved Hide resolved
@ferrarimarco ferrarimarco added this pull request to the merge queue Jun 19, 2024
@ferrarimarco
Copy link
Collaborator Author

Thanks for the review @zkoppert

Merged via the queue into main with commit c99ec77 Jun 19, 2024
106 checks passed
@ferrarimarco ferrarimarco deleted the fix-ansible-lint-pwd branch June 19, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Super-linter does not find Ansible playbooks when ANSIBLE_DIRECTORY=.
2 participants