Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PromiseKit #148

Closed
khoi opened this issue Jun 8, 2020 · 4 comments
Closed

Remove PromiseKit #148

khoi opened this issue Jun 8, 2020 · 4 comments

Comments

@khoi
Copy link

khoi commented Jun 8, 2020

I briefly look through the list of dependencies and see both PromiseKit and RxSwift. Why does the app need PromiseKit? Isn't Rx Single basically the same thing?

@antranapp
Copy link
Collaborator

I don't know much about RxSwift or Single, but the beauty of PromiseKit is that you can chain the async calls. I assume we can also do that with Single and map or flatMap. And That's why we have this ticket 😉

To be honest, I'm a very beginner when talking about RxSwift, only familiar with PromiseKit, if you could help to remove PromiseKit dependency by using RxSwift, it would be a huge help.

@antranapp
Copy link
Collaborator

antranapp commented Jun 8, 2020

Or we can skip RxSwift altogether and go straight to Combine using Future type as a replacement for PromiseKit 😆

@antranapp
Copy link
Collaborator

Haha, just found out that I've planned to remove both RxSwift & PromiseKit in another ticket already #104 😬

@khoi
Copy link
Author

khoi commented Jun 9, 2020

great

@khoi khoi closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants