Add support for fish paths and arrays #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for your PR! Your interest in this project means a lot to me. Your issue raised in #162 is definitely one that should be fixed. From a quick glance, your PR looks very solid. I can also see that you've made quite a few improvements to my code, which I appreciate. Unfortunately, I'm a bit busy at the moment, so I might not have time to provide a complete review and get this merged for about a week. I apologize for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a feature enhancement allowing users to distinguish between arrays and path series in the
fishshell when usingxshe. Previously,xshetreated all array inputs as path series, appending the--pathargument by default, which limited the usage of non-path arrays.The update is backwards compatible. Users can now explicitly pass a regular array by using a nested array structure. For example, specifying [["array_element_1", "array_element_2"]] leads to the input being treated as a standard array and flattened when the environment variable is processed.
The PR updates dependencies and resolves several issues that arose from the update.
Closes #162. Furthermore, this PR closes #83 by implementing the
XSHE_CONFIGenvironment variable.