You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now you can pass an array containing upload config to writeStream, updateStream etc. after retrieving the filesystem driver via $disk->getDriver() which will essentially pass the arguments to protected function upload($path, $contents, Config $config)
where the actual config of the google bucket upload happens.
I noticed, that the config arguments are prepared by another function:
protected function getOptionsFromConfig(Config $config)
{
$options = [];
if ($visibility = $config->get('visibility')) {
$options['predefinedAcl'] = $this->getPredefinedAclForVisibility($visibility);
} else {
// if a file is created without an acl, it isn't accessible via the console
// we therefore default to private
$options['predefinedAcl'] = $this->getPredefinedAclForVisibility(AdapterInterface::VISIBILITY_PRIVATE);
}
return $options;
})
The problem I have is, that only the 'visibility' argument from $config is actually parsed, additional arguments like 'chunkSize' or 'resumable' that are essential for chunked file uploads are discarded.
I would suggest adding something along the line of this, to enable those features:
if ($config->has('chunkSize')) {
$options['chunkSize'] = $config->get('chunkSize');
}
if ($config->has('resumable')) {
$options['resumable'] = $config->get('resumable');
}
The text was updated successfully, but these errors were encountered:
Right now you can pass an array containing upload config to writeStream, updateStream etc. after retrieving the filesystem driver via $disk->getDriver() which will essentially pass the arguments to
protected function upload($path, $contents, Config $config)
where the actual config of the google bucket upload happens.
I noticed, that the config arguments are prepared by another function:
The problem I have is, that only the 'visibility' argument from $config is actually parsed, additional arguments like 'chunkSize' or 'resumable' that are essential for chunked file uploads are discarded.
I would suggest adding something along the line of this, to enable those features:
The text was updated successfully, but these errors were encountered: