Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forBiomesOfTypes() does not respect previously set types [1.12.2] #288

Open
Igfig opened this issue Oct 30, 2022 · 0 comments
Open

forBiomesOfTypes() does not respect previously set types [1.12.2] #288

Igfig opened this issue Oct 30, 2022 · 0 comments

Comments

@Igfig
Copy link

Igfig commented Oct 30, 2022

If I run the following script:

swamp = forBiomes("minecraft:swampland")
swamp.removeDicTypes("WET")

wet = forBiomesOfTypes("WET")
wet.removeSpawn("net.minecraft.entity.passive.EntityCow", "CREATURE")

I would expect to see cows still spawning in swamps. What actually happens is that cows get removed from Swampland as if the biome were still WET.

Presumably the forBiomesOfTypes() is being run against the original biome dictionary, instead of the one modified by removeDicTypes(). It's possible that this is intended behaviour, but it doesn't seem correct to me.

I can't see a workaround short of explicitly removing "minecraft:swampland" from wet, which kinda misses the point of the first part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant