Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For a release, devs need to manually create source-code tarballs for sc3-plugins #134

Closed
kristho91 opened this issue Dec 27, 2016 · 6 comments

Comments

@kristho91
Copy link

kristho91 commented Dec 27, 2016

I'm getting following error when trying to build from the release tarball:

CMake Error at CMakeLists.txt:6 (message):
nova-simd submodule is missing: please run `git submodule init && git
submodule update' from the toplevel of your git working tree

This shouldn't be necessary, right? Or am I using the wrong tarball? (I am using this one: https://github.com/supercollider/sc3-plugins/archive/Version-3.8.0.tar.gz )

@vivid-synth
Copy link
Member

@kristho91 yes, this seems wrong. In the meantime you can

$ git pull https://github.com/supercollider/sc3-plugins
$ cd sc3-plugins
$ git submodule update --init --recursive

@danstowell
Copy link
Member

It's Github's fault. Github creates those tar.gz files automatically and github doesn't include submodules even though it should - see this issue discussed on the main supercollider codebase. It is not the fault of the supercollider developers, and the supercollider developers have no way of removing those defective tarballs.

@kristho91
Copy link
Author

@danstowell I know :) But could you maybe create a tarball that contains those submodules - like supercollider does on their own website?

@gusano
Copy link
Member

gusano commented Dec 29, 2016

@kristho91 Those tarballs (Source code (zip) and Source code (tar.gz)) are automagically created by github when creating a release and there's nothing we can do about it, as explained in the issue Dan mentioned. All other tarballs are updated manually and contain the submodules.

@danstowell danstowell changed the title Cannot build from release tarball For a release, devs need to manually create source-code tarballs for sc3-plugins Dec 29, 2016
@LFSaw
Copy link
Member

LFSaw commented May 10, 2017

we should

  1. file an issue for github
  2. mention it in the README?

@dvzrv
Copy link
Member

dvzrv commented Dec 16, 2018

Implemented with #186

@dvzrv dvzrv closed this as completed Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants