Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql model outputs query needs better way to define version #1656

Closed
kartik4949 opened this issue Jan 9, 2024 · 1 comment
Closed

Sql model outputs query needs better way to define version #1656

kartik4949 opened this issue Jan 9, 2024 · 1 comment
Assignees
Labels
📝 documentation Improvements or additions to documentation 📉 technical debt Things that slow us down

Comments

@kartik4949
Copy link
Collaborator

current way of model outputs retrieval in sql is

table.select(...).outputs(x='model_linear_a/0')

basically
key = '{model_name}/{version}'

we should define it better and document

@kartik4949 kartik4949 added 📝 documentation Improvements or additions to documentation 📉 technical debt Things that slow us down labels Jan 9, 2024
@kartik4949 kartik4949 self-assigned this Jan 9, 2024
@jieguangzhou
Copy link
Collaborator

jieguangzhou commented Jan 11, 2024

Maybe we can unify mongodb and ibis as

query: select.outputs(field=“x”, model=“model_linear_a”, version=0 / None)
outputs: document.outputs(field=“x”, model=“model_linear_a”, version=0 / None)

WDYT? @kartik4949

@blythed blythed closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 documentation Improvements or additions to documentation 📉 technical debt Things that slow us down
Projects
None yet
Development

No branches or pull requests

3 participants