Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONSOLE] show deployed protocol version #186

Open
d10r opened this issue Aug 23, 2023 · 2 comments · Fixed by #192
Open

[CONSOLE] show deployed protocol version #186

d10r opened this issue Aug 23, 2023 · 2 comments · Fixed by #192
Assignees
Labels
Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Enhancement New feature or request

Comments

@d10r
Copy link
Contributor

d10r commented Aug 23, 2023

With the 1.8 release, we get a versionString in Resolver which tells us what's deployed.
This version string includes the ethereum-contracts package version and the git revision (leading 16 digits).

The information is store in the Resolver under the key versionString.v1.
Since the Resolver only supports address values, it needs to be parsed like that: https://github.com/superfluid-finance/protocol-monorepo/blob/dev/packages/ethereum-contracts/ops-scripts/libs/common.js#L442

  • Add a new tab for versions including
    • Protocol contracts
    • Peripheral contracts
    • Subgraph
    • Sentinels (compatible version number)
@d10r d10r added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Sep 28, 2023
@d10r d10r self-assigned this Sep 28, 2023
@hellwolf hellwolf added the Type: Enhancement New feature or request label Oct 4, 2023
@hellwolf hellwolf assigned 0xdavinchee and unassigned d10r Oct 5, 2023
@0xdavinchee 0xdavinchee linked a pull request Oct 5, 2023 that will close this issue
@d10r
Copy link
Contributor Author

d10r commented Jan 4, 2024

There's something wrong.
After upgrading the protocol contracts for polygon-mumbai, it's supposed to show 1.8.1-b182e1dac38615d4.
But keeps showing 1.8.1-b50c82f4a96d2425 in the console.

console link: https://console.superfluid.finance/mumbai/protocol

resolver: https://mumbai.polygonscan.com/address/0x2feFd8B23e4770B674b0d2fAda5EE8a2bE0B525F#readContract

image

image

@d10r d10r reopened this Jan 4, 2024
@0xdavinchee
Copy link
Contributor

good catch @d10r if I had to guess it is because we've redeployed the resolvers + updated it in metadata.json, but we haven't released SDK-Core/Redux to use the new metadata or bumped the version used by the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants