Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[console] fix bug of old persisted state for a network crashing the view #211

Closed
kasparkallas opened this issue Feb 20, 2024 · 0 comments · Fixed by #216
Closed

[console] fix bug of old persisted state for a network crashing the view #211

kasparkallas opened this issue Feb 20, 2024 · 0 comments · Fixed by #216
Assignees
Labels
Severity: Medium Tag: Quality Related to the quality topic Tag: UX Related to the user experience topic Type: Bug Something isn't working

Comments

@kasparkallas
Copy link
Collaborator

kasparkallas commented Feb 20, 2024

What?

Users can set preferences for test networks for themselves. Those preferences are stored in the local state. When a network is removed and the user had a preference for that network then the app crashes. The fix is to clear the local state.

Why?

It's not a good look and it will surface again in the future. The fix is very destructive for the end-user if they have other local state (like the address book).

How?

  • soft delete the networks instead
  • add some error boundaries (even if there's a error in some of the components, it shouldn't bring the whole app down)
  • remove the expectation that all the networks exist that are stored in the local state
@kasparkallas kasparkallas added Severity: Medium Tag: Quality Related to the quality topic Tag: UX Related to the user experience topic Type: Bug Something isn't working labels Feb 20, 2024
@kasparkallas kasparkallas self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: Medium Tag: Quality Related to the quality topic Tag: UX Related to the user experience topic Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant