-
Notifications
You must be signed in to change notification settings - Fork 224
/
config_update.go
480 lines (407 loc) · 12.3 KB
/
config_update.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
package postgres
import (
"context"
"fmt"
"strconv"
"strings"
"github.com/pkg/errors"
"github.com/r3labs/diff"
"github.com/spf13/cobra"
"github.com/superfly/flyctl/agent"
"github.com/superfly/flyctl/api"
"github.com/superfly/flyctl/client"
"github.com/superfly/flyctl/flypg"
"github.com/superfly/flyctl/internal/appconfig"
"github.com/superfly/flyctl/internal/command"
"github.com/superfly/flyctl/internal/command/apps"
"github.com/superfly/flyctl/internal/flag"
mach "github.com/superfly/flyctl/internal/machine"
"github.com/superfly/flyctl/internal/prompt"
"github.com/superfly/flyctl/internal/render"
"github.com/superfly/flyctl/iostreams"
)
func newConfigUpdate() (cmd *cobra.Command) {
const (
long = `Update Postgres configuration.`
short = "Update Postgres configuration."
usage = "update"
)
cmd = command.New(usage, short, long, runConfigUpdate,
command.RequireSession,
command.RequireAppName,
)
flag.Add(cmd,
flag.App(),
flag.AppConfig(),
flag.Detach(),
flag.String{
Name: "max-connections",
Description: "Sets the maximum number of concurrent connections.",
},
flag.String{
Name: "shared-buffers",
Description: "Sets the amount of memory the database server uses for shared memory buffers",
},
flag.String{
Name: "wal-level",
Description: "Sets the level of information written to the WAL. (minimal, replica, logical).",
},
flag.String{
Name: "max-wal-senders",
Description: "Maximum number of concurrent connections from standby servers or streaming backup clients. (0 disables replication)",
},
flag.String{
Name: "max-replication-slots",
Description: "Specifies the maximum number of replication slots. This should typically match max_wal_senders.",
},
flag.String{
Name: "log-statement",
Description: "Sets the type of statements logged. (none, ddl, mod, all)",
},
flag.String{
Name: "log-min-duration-statement",
Description: "Sets the minimum execution time above which all statements will be logged. (ms)",
},
flag.String{
Name: "shared-preload-libraries",
Description: "Sets the shared libraries to preload. (comma separated string)",
},
flag.Bool{
Name: "force",
Description: "Skips pg-setting value verification.",
},
flag.Yes(),
)
return
}
func runConfigUpdate(ctx context.Context) error {
var (
client = client.FromContext(ctx).API()
appName = appconfig.NameFromContext(ctx)
)
app, err := client.GetAppCompact(ctx, appName)
if err != nil {
return fmt.Errorf("failed retrieving app %s: %w", appName, err)
}
if !app.IsPostgresApp() {
return fmt.Errorf("app %s is not a postgres app", appName)
}
ctx, err = apps.BuildContext(ctx, app)
if err != nil {
return err
}
switch app.PlatformVersion {
case "machines":
return runMachineConfigUpdate(ctx, app)
case "nomad":
return runNomadConfigUpdate(ctx, app)
default:
return fmt.Errorf("unknown platform version")
}
}
func runMachineConfigUpdate(ctx context.Context, app *api.AppCompact) error {
var (
io = iostreams.FromContext(ctx)
colorize = io.ColorScheme()
autoConfirm = flag.GetBool(ctx, "yes")
MinPostgresHaVersion = "0.0.33"
MinPostgresStandaloneVersion = "0.0.7"
MinPostgresFlexVersion = "0.0.6"
)
machines, releaseLeaseFunc, err := mach.AcquireAllLeases(ctx)
defer releaseLeaseFunc(ctx, machines)
if err != nil {
return fmt.Errorf("machines could not be retrieved")
}
if err := hasRequiredVersionOnMachines(machines, MinPostgresHaVersion, MinPostgresFlexVersion, MinPostgresStandaloneVersion); err != nil {
return err
}
leader, err := pickLeader(ctx, machines)
if err != nil {
return err
}
manager := flypg.StolonManager
if IsFlex(leader) {
manager = flypg.ReplicationManager
}
requiresRestart := false
switch manager {
case flypg.ReplicationManager:
requiresRestart, err = updateFlexConfig(ctx, app, leader.PrivateIP)
if err != nil {
return err
}
default:
requiresRestart, err = updateStolonConfig(ctx, app, leader.PrivateIP)
if err != nil {
return err
}
}
if requiresRestart {
if !autoConfirm {
fmt.Fprintln(io.Out, colorize.Yellow("Please note that some of your changes will require a cluster restart before they will be applied."))
switch confirmed, err := prompt.Confirm(ctx, "Restart cluster now?"); {
case err == nil:
if !confirmed {
return nil
}
case prompt.IsNonInteractive(err):
return prompt.NonInteractiveError("yes flag must be specified when not running interactively")
default:
return err
}
}
// Ensure leases are released before we issue restart.
releaseLeaseFunc(ctx, machines)
if err := machinesRestart(ctx, &api.RestartMachineInput{}); err != nil {
return err
}
}
return nil
}
func updateStolonConfig(ctx context.Context, app *api.AppCompact, leaderIP string) (bool, error) {
io := iostreams.FromContext(ctx)
restartRequired, changes, err := resolveConfigChanges(ctx, app, flypg.StolonManager, leaderIP)
if err != nil {
return false, err
}
fmt.Fprintln(io.Out, "Performing update...")
cmd, err := flypg.NewCommand(ctx, app)
if err != nil {
return false, err
}
err = cmd.UpdateSettings(ctx, leaderIP, changes)
if err != nil {
return false, err
}
fmt.Fprintln(io.Out, "Update complete!")
return restartRequired, nil
}
func updateFlexConfig(ctx context.Context, app *api.AppCompact, leaderIP string) (bool, error) {
var (
io = iostreams.FromContext(ctx)
dialer = agent.DialerFromContext(ctx)
)
restartRequired, changes, err := resolveConfigChanges(ctx, app, flypg.ReplicationManager, leaderIP)
if err != nil {
return false, err
}
fmt.Fprintln(io.Out, "Performing update...")
leaderClient := flypg.NewFromInstance(leaderIP, dialer)
// Push configuration settings to consul.
if err := leaderClient.UpdateSettings(ctx, changes); err != nil {
return false, err
}
machines, err := mach.ListActive(ctx)
if err != nil {
return false, err
}
// Sync configuration settings for each node. This should be safe to apply out-of-order.
for _, machine := range machines {
if machine.Config.Env["IS_BARMAN"] != "" {
continue
}
client := flypg.NewFromInstance(machine.PrivateIP, dialer)
// Pull configuration settings down from Consul for each node and reload the config.
err := client.SyncSettings(ctx)
if err != nil {
return false, fmt.Errorf("failed to sync configuration on %s: %s", machine.ID, err)
}
}
fmt.Fprintln(io.Out, "Update complete!")
return restartRequired, nil
}
func resolveConfigChanges(ctx context.Context, app *api.AppCompact, manager string, leaderIP string) (bool, map[string]string, error) {
var (
io = iostreams.FromContext(ctx)
dialer = agent.DialerFromContext(ctx)
force = flag.GetBool(ctx, "force")
autoConfirm = flag.GetYes(ctx)
)
// Identify requested configuration changes.
changes := map[string]string{}
keys := []string{}
for key := range pgSettings {
val := flag.GetString(ctx, key)
if val != "" {
changes[pgSettings[key]] = val
keys = append(keys, pgSettings[key])
}
}
restartRequired := false
if !force {
// Query PG settings
pgclient := flypg.NewFromInstance(leaderIP, dialer)
settings, err := pgclient.ViewSettings(ctx, keys, manager)
if err != nil {
return false, nil, err
}
if len(changes) == 0 {
return false, nil, fmt.Errorf("no changes were specified")
}
changelog, err := resolveChangeLog(ctx, changes, settings)
if err != nil {
return false, nil, err
}
if len(changelog) == 0 {
return false, nil, fmt.Errorf("no changes to apply")
}
rows := make([][]string, 0, len(changelog))
for _, change := range changelog {
requiresRestart := isRestartRequired(settings, change.Path[len(change.Path)-1])
if requiresRestart {
restartRequired = true
}
name := strings.ReplaceAll(change.Path[len(change.Path)-1], "_", "-")
rows = append(rows, []string{
name,
fmt.Sprint(change.From),
fmt.Sprint(change.To),
fmt.Sprint(requiresRestart),
})
}
render.Table(io.Out, "", rows, "Name", "Value", "Target value", "Restart Required")
if !autoConfirm {
const msg = "Are you sure you want to apply these changes?"
switch confirmed, err := prompt.Confirmf(ctx, msg); {
case err == nil:
if !confirmed {
return false, nil, nil
}
case prompt.IsNonInteractive(err):
return false, nil, prompt.NonInteractiveError("yes flag must be specified when not running interactively")
default:
return false, nil, err
}
}
}
return restartRequired, changes, nil
}
func resolveChangeLog(ctx context.Context, changes map[string]string, settings *flypg.PGSettings) (diff.Changelog, error) {
// Verify that input values are within acceptible ranges.
// Stolon does not verify this, so we need to do it here.
for k, v := range changes {
for _, setting := range settings.Settings {
if setting.Name == k {
if err := validateConfigValue(setting, k, v); err != nil {
return nil, err
}
}
}
}
// Construct a map of the active configuration settings so we can compare.
oValues := map[string]string{}
for _, setting := range settings.Settings {
oValues[setting.Name] = setting.Setting
}
// Calculate diff
return diff.Diff(oValues, changes)
}
func isRestartRequired(pgSettings *flypg.PGSettings, name string) bool {
for _, s := range pgSettings.Settings {
if s.Name == name {
if s.Context == "postmaster" {
return true
}
}
}
return false
}
func runNomadConfigUpdate(ctx context.Context, app *api.AppCompact) error {
var (
client = client.FromContext(ctx).API()
io = iostreams.FromContext(ctx)
colorize = io.ColorScheme()
autoConfirm = flag.GetBool(ctx, "yes")
MinPostgresVersion = "v0.0.32"
)
if err := hasRequiredVersionOnNomad(app, MinPostgresVersion, MinPostgresVersion); err != nil {
return err
}
agentclient, err := agent.Establish(ctx, client)
if err != nil {
return errors.Wrap(err, "can't establish agent")
}
pgInstances, err := agentclient.Instances(ctx, app.Organization.Slug, app.Name)
if err != nil {
return fmt.Errorf("failed to lookup 6pn ip for %s app: %v", app.Name, err)
}
if len(pgInstances.Addresses) == 0 {
return fmt.Errorf("no 6pn ips found for %s app", app.Name)
}
leaderIP, err := leaderIpFromNomadInstances(ctx, pgInstances.Addresses)
if err != nil {
return err
}
requiresRestart, err := updateStolonConfig(ctx, app, leaderIP)
if err != nil {
return err
}
if requiresRestart {
if !autoConfirm {
fmt.Fprintln(io.Out, colorize.Yellow("Please note that some of your changes will require a cluster restart before they will be applied."))
switch confirmed, err := prompt.Confirm(ctx, "Restart cluster now?"); {
case err == nil:
if !confirmed {
return nil
}
case prompt.IsNonInteractive(err):
return prompt.NonInteractiveError("yes flag must be specified when not running interactively")
default:
return err
}
}
if err := nomadRestart(ctx, app); err != nil {
return err
}
}
return nil
}
func validateConfigValue(setting flypg.PGSetting, key, val string) error {
switch setting.VarType {
case "enum":
for _, enumVal := range setting.EnumVals {
if enumVal == val {
return nil
}
}
return fmt.Errorf("invalid value specified for %s. Received: %s, Accepted values: [%s]", key, val, strings.Join(setting.EnumVals, ", "))
case "integer":
min, err := strconv.Atoi(setting.MinVal)
if err != nil {
return err
}
max, err := strconv.Atoi(setting.MaxVal)
if err != nil {
return err
}
v, err := strconv.Atoi(val)
if err != nil {
return err
}
if v < min || v > max {
return fmt.Errorf("invalid value specified for %s. (Received: %s, Accepted range: (%s, %s)", key, val, setting.MinVal, setting.MaxVal)
}
case "real":
min, err := strconv.ParseFloat(setting.MinVal, 32)
if err != nil {
return err
}
max, err := strconv.ParseFloat(setting.MaxVal, 32)
if err != nil {
return err
}
v, err := strconv.ParseFloat(val, 32)
if err != nil {
return err
}
if v < min || v > max {
return fmt.Errorf("invalid value specified for %s. (Received: %s, Accepted range: (%.1f, %.1f)", key, val, min, max)
}
case "bool":
if val != "on" && val != "off" {
return fmt.Errorf("invalid value specified for %s. (Received: %s, Accepted values: [on, off]", key, val)
}
}
return nil
}