Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI improvement: switching between accounts and multisig vaults #3034

Open
peronczyk opened this issue May 15, 2024 · 1 comment · May be fixed by #2312
Open

UI improvement: switching between accounts and multisig vaults #3034

peronczyk opened this issue May 15, 2024 · 1 comment · May be fixed by #2312
Assignees
@peronczyk @onvisions

Comments

@peronczyk
Copy link
Collaborator

This task is a follow up to this one: #2602

The suggestion is to rethink the way how we switch between regular dashboard (accounts) and multisig vaults. Right now the button that allows to do this is placed under the account cards which might be misleading. In general common way to switch between options (screens) should be done be element placed over the screens. For example in most cases tabs are placed above the controlled content.

My suggestion:
Image

@onvisions what do you think?
@peronczyk
Copy link
Collaborator Author

I created quick demo to test my idea: https://feat-accounts-and-vaults-view-switcher.wallet.z52da5wt.xyz/
@onvisions

@peronczyk peronczyk linked a pull request May 16, 2024 that will close this issue
[DRAFT][POC] Feat: New Accounts and Vaults view switcher #2312
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peronczyk peronczyk

@onvisions onvisions

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DRAFT][POC] Feat: New Accounts and Vaults view switcher superhero-com/superhero-wallet
2 participants
@peronczyk @onvisions