Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SuperTextField demo app #1598

Open
matthew-carroll opened this issue Nov 14, 2023 · 5 comments
Open

Improve SuperTextField demo app #1598

matthew-carroll opened this issue Nov 14, 2023 · 5 comments
Labels
area_supertextfield Pertains to SuperTextField bounty_junior f:superlist Funded by Superlist time:2

Comments

@matthew-carroll
Copy link
Contributor

We added an entrypoint specifically to demo SuperTextField in this PR: #1596

That work is a start, but we can create a more compelling demo app for SuperTextField.

Implement the following:

  • Toggleable light mode and dark mode, which is respected by the SuperTextFields
  • Start with a single text field of a single line. Make it possible to add more SuperTextFields in a vertical column.
  • Make it possible to select a SuperTextField and alter various characteristics in a settings pane, e.g., line count, border color, etc.
  • Adapts the overall layout for mobile vs desktop
@matthew-carroll matthew-carroll added area_supertextfield Pertains to SuperTextField bounty_junior f:superlist Funded by Superlist time:2 labels Nov 14, 2023
@foxtrotravi
Copy link

Hi @matthew-carroll I would like to contribute to this. I will create a PR for this soon.

@foxtrotravi
Copy link

@matthew-carroll

I am a little confused about this point:

  • Start with a single text field of a single line. Make it possible to add more SuperTextFields in a vertical column.

Please correct me if I am wrong. Should I add a + button to add multiple SuperTextFields in the Column vertically?

@foxtrotravi
Copy link

We added an entrypoint specifically to demo SuperTextField in this PR: #1596

That work is a start, but we can create a more compelling demo app for SuperTextField.

Implement the following:

  • Toggleable light mode and dark mode, which is respected by the SuperTextFields
  • Start with a single text field of a single line. Make it possible to add more SuperTextFields in a vertical column.
  • Make it possible to select a SuperTextField and alter various characteristics in a settings pane, e.g., line count, border color, etc.
  • Adapts the overall layout for mobile vs desktop

I have pushed 3/4 tasks mentioned in the issue above. Please let me know about the following query & I will add that in the PR.

  • Start with a single text field of a single line. Make it possible to add more SuperTextFields in a vertical column.

cc - @matthew-carroll

@matthew-carroll
Copy link
Contributor Author

Hi @foxtrotravi thanks for your desire to contribute. This ticket is meant for me - it's a note to myself. I see you've done some good work assembling text field variations. I appreciate that effort. But it's not quite what I had in mind. If you really want to work on this, I can put together a few design mockups. Let me know if that's something you want to do.

In general, you should wait for a ticket to be assigned before working on it. We have all sorts of things going on behind the scenes that might interfere with your ability to implement a ticket.

I'm not sure we have any other tickets right now that have a clear goal for new project developers.

@foxtrotravi
Copy link

Hi @matthew-carroll Yeah, I totally understand that I should have waited for the ticket to be assigned.
I really want to contribute to this project. That's why I started working on it. It would be awesome if you could provide the mockup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area_supertextfield Pertains to SuperTextField bounty_junior f:superlist Funded by Superlist time:2
Projects
None yet
Development

No branches or pull requests

2 participants