feat(#45): Migrate add-on from custom resource to CfnAddon construct #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to align this project with the progress of CloudFormation and CDK move away from custom resources for creation of add-ons. To migrate an exisiting cluster: * Remove the add-on via web console or cli * re-deploy the updated stack * Add the add-on via web console or cli using the pre-deployed role (same version as before, choose "resolve conflicts")
3oris
force-pushed
the
feat/75-migrate-to-cfn-aws-eks-addon
branch
from
130f124
to
fbf1258
Compare
|
While CDK itself doesn't seems to follow the inheritance approach, like we discussed today, i do like it here, so 👍 :D |
Miradorn
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to align this project with the progress of CloudFormation and CDK
move away from custom resources for creation of add-ons.
To migrate an exisiting cluster:
(same version as before, choose "resolve conflicts")
Fixes #75