Skip to content
This repository has been archived by the owner on Dec 12, 2018. It is now read-only.

Clean up #13

Closed
wants to merge 3 commits into from
Closed

Clean up #13

wants to merge 3 commits into from

Conversation

kevinrenskers
Copy link
Contributor

Naming consistency: all categories are now named +ObjectiveSugar. Tests all pass.

Removed pods from the git repo. I don't think this was ever intended to be committed? I've also moved the .gitignore file to the top most level, where it should be for it to work properly.

@supermarin
Copy link
Owner

Thanks for the pull request!

I'll merge just the 6283d3a for now, as the .gitignore is really related to SampleProject only. (you can see that the Podfile.lock hanen't been ignored properly).

Since it's just a sample project, and our unit testing project, maybe it's easier for other devs if Pods are just there.

@supermarin supermarin closed this Dec 18, 2012
@kevinrenskers
Copy link
Contributor Author

That's what pod install is for, right? :) To put something in your repo that can be easily installed in another way doesn't seem like a good solution. Also, you're missing the workspace file in the repo then, so right now the pods don't do much.

@supermarin
Copy link
Owner

@kevinrenskers woah, well that's a good point; I haven't noticed it has been (somehow) ignored.

The point was that you can just check out the project and develop on it (not be dependent on kiwi changes etc).
But I'll consider merging that.

@kevinrenskers
Copy link
Contributor Author

Probably better to lock the versions of the pods, so you are always in a known state?

@supermarin
Copy link
Owner

Sounds good.
I'll think about that today, the only downside for me is that developers that don't have cocoapods installed won't be able to contribute / run tests.

@kevinrenskers
Copy link
Contributor Author

iOS developers that don't use cocoapods should start anyways :D Plus, it's only a one line install.
I'll stop now, let you make up your mind :)
Again, thanks for the project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants