Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's provide the primitives #49

Closed
jonasfj opened this issue Dec 22, 2016 · 4 comments
Closed

Let's provide the primitives #49

jonasfj opened this issue Dec 22, 2016 · 4 comments

Comments

@jonasfj
Copy link
Contributor

jonasfj commented Dec 22, 2016

As I understand primitives: https://aframe.io/docs/0.4.0/primitives/

They are just a-entity tags with a nice combination of components and default values, as well a easy access attributes.

We could probably implement them all very quickly, any reason not to provide them?

@ngokevin
Copy link
Collaborator

What would be the reason to provide them? They are usable as is from aframe-react, there's even a primitive prop.

@jonasfj
Copy link
Contributor Author

jonasfj commented Dec 22, 2016

I couldn't do <Entity id="pine" primitive="a-collada-model" src="#pine2" position="0 0 -15" />
For some reason the src property isn't passed down... I think had similar issues with other primitives.

Maybe I'm missing something, or maybe we're missing that specific property somewhere...
I'll admit anything 3d is far outside my comfort zone - I'm just having some holiday fun :)

@ngokevin
Copy link
Collaborator

There was a PR today to fix primitives, there was a typo, I released that version

You could also just use <a-collada-model>.

Hope it's fun :)

@jonasfj
Copy link
Contributor Author

jonasfj commented Dec 22, 2016

Oh, I didn't know that worked in react... nevermind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants