Skip to content
This repository has been archived by the owner on Mar 5, 2021. It is now read-only.

Catch Ctrl+C and make sure server is stopped properly #28

Closed
elisee opened this issue Apr 9, 2016 · 4 comments
Closed

Catch Ctrl+C and make sure server is stopped properly #28

elisee opened this issue Apr 9, 2016 · 4 comments

Comments

@elisee
Copy link
Contributor

elisee commented Apr 9, 2016

Just like in the server itself: https://github.com/superpowers/superpowers-core/blob/39cd9e57aa882ab651a7600e328dcf772ff0aed2/server/commands/start.ts#L100

@elisee
Copy link
Contributor Author

elisee commented Apr 10, 2016

Gave it a shot in a branch, but it does not seem to work well. It only works some of the time, sometimes the log message is cut off in the middle.

I assume this is an Electron bug of some sort, as of v0.37.5.

@elisee
Copy link
Contributor Author

elisee commented Apr 24, 2016

Confirmed a bug, reported it as electron/electron#5273 and committed commented-out code in c6c704e.

@bilou84
Copy link
Contributor

bilou84 commented Jul 23, 2016

Latest news on the issue is that the bug can't (and so won't) be fixed. What should we do on our end?

@elisee
Copy link
Contributor Author

elisee commented Jul 26, 2016

I guess we can't do much. Basically: don't use Ctrl+C when running the app from the command line if you don't want to stopping the server brutally.

Closing as "won't fix", feel free to reopen if new development in Electron happens.

@elisee elisee closed this as completed Jul 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants