Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] For video attachments, store + return fps, bitrate, duration #1282

Merged
merged 11 commits into from Dec 22, 2022

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This PR reworks some of our mp4 parsing logic, to also derive video bit rate, duration, and framerate information. This is stored in the database and then serialized to clients via the API.

This brings GtS closer in line with the Mastodon API, which also serves these fields via the client API. This should hopefully resolve some issues where videos weren't playing in some clients.

Also adds tests for the above :)

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

@tsmethurst have left some comments but after those are fixed up it looks good to me :)

@tsmethurst tsmethurst merged commit 1659f75 into main Dec 22, 2022
@tsmethurst tsmethurst deleted the mp4_jiggery_pokery branch December 22, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants