Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] set max open / idle conns + conn max lifetime for both postgres and sqlite #1369

Merged
merged 7 commits into from Jan 26, 2023

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Jan 22, 2023

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This PR updates some of our database tuning. Previously we were only setting maxopenconns and maxidleconns for postgres, and only setting connmaxlifetime(0) for in-mem sqlite connections, to avoid the db being deleted on connection cleanup.

Now, this tuning has been combined and is done for both database types. This is partially because we should have already been setting maxopenconns and maxidleconns for sqlite but weren't, and also to see if some SQLITE_BUSY errors can be resolved by never letting sqlite connections die (see https://www.sqlite.org/wal.html#sometimes_queries_return_sqlite_busy_in_wal_mode)

The PR also reduces the default cache size for sqlite connections to 8MiB, since 64MiB ended up using rather a lot of memory.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code. -- n/a
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor Author

This seems pretty decent now so i'm gonna merge and we can still play around with some of the values on main as necessary! :)

@tsmethurst tsmethurst merged commit 782169d into main Jan 26, 2023
@tsmethurst tsmethurst deleted the db_tweaking branch January 26, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant