Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add certificates and firewalling to advanced #1888

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

daenney
Copy link
Member

@daenney daenney commented Jun 13, 2023

Description

This adds another 2 pieces of documentation to the Advanced section:

  • Certificates, to give people more pointers on how to provision them
  • Firewall, for more information on how to configure one appropriately

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

This adds some documentation about the process of getting certificates
through ACME in general. It also provides a number of links to
alternative clients and certbot deployment guides that are up to date.

Slightly restructure the NGINX and Apache reverse proxy documentation
and insert mentions to the Provisioning TLS certificates advanced
documentation in them.
@daenney
Copy link
Member Author

daenney commented Jun 13, 2023

Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work as usual :) couple typos then i reckon this is good to merge; thank you so much!

docs/advanced/certificates.md Outdated Show resolved Hide resolved

### IPv6

ICMP is heavily relied on by all parts of the IPv6 stack and things will break in exciting and hard to debug ways if you block it. [RFC 4890](https://www.rfc-editor.org/rfc/rfc4890) was specifically written to address this and is worthwhile to review.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things will break in exciting and hard to debug ways

:')

docs/getting_started/reverse_proxy/nginx.md Outdated Show resolved Hide resolved
@daenney
Copy link
Member Author

daenney commented Jun 13, 2023

Got 'em. I actually fixed my spell checker in my editor but seems I missed a few nonetheless. Thanks for catching them!

@tsmethurst tsmethurst merged commit 433b56d into superseriousbusiness:main Jun 13, 2023
2 checks passed
@daenney daenney deleted the docs-security branch June 13, 2023 16:54
tsmethurst pushed a commit that referenced this pull request Jun 14, 2023
* [docs] Add a certificates guide in Advanced

This adds some documentation about the process of getting certificates
through ACME in general. It also provides a number of links to
alternative clients and certbot deployment guides that are up to date.

Slightly restructure the NGINX and Apache reverse proxy documentation
and insert mentions to the Provisioning TLS certificates advanced
documentation in them.

* [docs] Add firewall section in Advanced

* [docs] Add new guides to section indexes

* [docs] Fix spelling issue

* [docs] Fix a few typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants