Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Explain how to secure metrics endpoints #2382

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

daenney
Copy link
Member

@daenney daenney commented Nov 23, 2023

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@daenney daenney marked this pull request as draft November 23, 2023 17:58
@daenney
Copy link
Member Author

daenney commented Nov 23, 2023

This needs some reworking integration with advanced/metrics.

@daenney daenney marked this pull request as ready for review November 23, 2023 18:16
@daenney
Copy link
Member Author

daenney commented Nov 23, 2023

Alright, that's better.

@tsmethurst
Copy link
Contributor

nice one! :)

@tsmethurst tsmethurst merged commit c334df8 into main Nov 26, 2023
3 checks passed
@tsmethurst tsmethurst deleted the docs-metrics-protect branch November 26, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants