Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GtS reported version SemVer-compatible #2611

Merged

Conversation

VyrCossont
Copy link
Contributor

Description

This pull request makes GtS's version string compatible with SemVer by concatenating the VCS metadata with the version using a plus sign (SemVer's build tag separator) instead of a space. It relies on main.Version being set to a SemVer-compatible version, which should be the case for release and most development builds.

Fixes #1953

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

One character change, nice! Looks fine to me, and I can't think of any negatives for doing things this way. @NyaaaWhatsUpDoc any thots?

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 54ca2cf into superseriousbusiness:main Feb 12, 2024
2 checks passed
@VyrCossont VyrCossont deleted the semver-build-tag branch February 14, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] SemVer version in /api/vX/instance and /nodeinfo/2.0
4 participants