Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Increase default max image description to 1500 chars, collapse cw char count into status #2682

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request removes some of the friction of using Mastodon clients on GtS by bringing some of our character counts more in line with Mastodon:

  • Increase default image description char count from 500 => 1500 (the Mastodon default). There's no real reason we had such a limited default in the first place.
  • Remove the statuses-cw-max-chars config option, and just add cw and body text together when checking that a status is within character limits. This is also closer to the Mastodon behavior, and so should cause fewer issues in clients (like Tusky, for example) which provide a total character count that includes the cw. Technically this is a reduction in how many characters are permitted by default in a GtS status, but admins can always bump their character count up to 5500 or something if they want to.

Partially addresses #2457, but doesn't quite close it since we don't count links as 23 characters etc.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 4b0eefb into main Feb 23, 2024
3 checks passed
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the media_description_cw_tweaks branch February 23, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants