New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] bump go structr cache version -> v0.6.0 #2773
Merged
tsmethurst
merged 6 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:chore/bump-go-structr-cache-version
Apr 2, 2024
Merged
[chore] bump go structr cache version -> v0.6.0 #2773
tsmethurst
merged 6 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:chore/bump-go-structr-cache-version
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyaaaWhatsUpDoc
force-pushed
the
chore/bump-go-structr-cache-version
branch
from
March 25, 2024 17:12
545bcd2
to
5462691
Compare
NyaaaWhatsUpDoc
force-pushed
the
chore/bump-go-structr-cache-version
branch
from
March 25, 2024 17:35
f2c1d61
to
d25478b
Compare
tsmethurst
reviewed
Mar 29, 2024
tsmethurst
reviewed
Apr 1, 2024
tsmethurst
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just the one question about the index map :) And the accidental test output commit ;)
Squerge when you're happy! |
tsmethurst
approved these changes
Apr 2, 2024
(Just merged main into this to fix the docs fail) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
go-structr
to v0.6.0, which made some incompatible API changes that this PR fixes. this latest version adds theQueue{}
type to the structr package which allows (in the future) for indexable queues.cache.GTS{}
caches to be struct value types instead of a mixture of values + ptrsstructr.Cache{}
wrapping type to simplify updating with the incompatible API changes + allows for much simpler loading of multiple IDs from cachesChecklist
go fmt ./...
andgolangci-lint run
.