Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Refactor settings panel routing (and other fixes) #2864

Merged
merged 1 commit into from Apr 24, 2024

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Apr 23, 2024

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

Mind-boggling refactor of our settings panel routing and menu stuff

  • Separate routing and menu building into submodules and make it so typescript works with them properly.
  • Removes some dependencies we were hardly using or not using.
  • Use latest version of wouter, and tidy up code issues that came from the upgrade (particularly round the Link component).
  • Type some more stuff.
  • Fix some small HTML errors (<a>s embedded inside <a>s, <p>s embedded inside <p>s, things like that).

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others. <-- hope so, that was the idea
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 7a1e639 into main Apr 24, 2024
3 checks passed
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the settings_routing_refactor branch April 24, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants