-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the SignInAndUpTheme #9
Comments
Sign Up UISign Up form with no Terms and condition checkbox (524 px width of white container)
Sign Up form with Terms and condition checkbox (524 px width of white container)
Sign Up form with no Terms and condition checkbox (420 px width of white container)
Sign Up form with Terms and condition checkbox (420 px width of white container)
Sign In UISign In form with Terms and condition checkbox (524 px width of white container)
Sign In form with Terms and condition checkbox (420 px width of white container)
Loading Screen
Sign out State
Notes
|
Notes on using default browser messages:
|
Updated comment above to include design of successful sign in/ sign up with sign out functionality |
@NkxxkN I have added the "Required state" design in the main comment above along with the conditions under which it should be rendered in the last point of notes. |
@mufassirkazi , you can change the design back to removing the checkbox for privacy policy and ToU.. instead, you can say "By signing up, you agree to..." Sorry about that miscommunication eariler. The above also seems to be OK from a GDPR point of view since a lot of large, global companies do that |
No problem. @NkxxkN I updated the designs again and the designs are listed under the headers "Sign Up form with no Terms and condition checkbox (524 px width of white container)" and "Sign Up form with no Terms and condition checkbox (420 px width of white container)" resp. |
@mufassirkazi are we sure we want to use orange as the default theme? As opposed to a more neutral colour like blue?
I prefer if we change it to a more neutral colour. But we can also do this later. |
Let's keep orange now. Even Auth0 keeps their brand color. |
So at the moment overriding css is pretty straightforward which is nice! But we don't have a good way to override the "orange" color everywhere (In the button, the input focus state and in the valid email check image). It can be done by overriding each properties in the Should we allow to override some CSS properties in Default palette: SuperTokens.init({
appInfo: {...},
palette: {
colors: {
background: "white",
inputBackground: "#f2f2f2",
primary: "#ff9b33",
secondary: "#656565",
link: "#0076ff",
error: "#ff1717",
textPrimary: "#222222"
},
fonts: {
size: [14, 16, 28]
}
}
} Override just the orange color: SuperTokens.init({
appInfo: {...},
palette: {
colors: {
primary: "blue"
}
}
} |
@NkxxkN . We should not have this in the Our default CSS is lower than palette is lower than their provided CSS in style prop In terms of what we allow them to change via this
|
@mufassirkazi please discuss the above with @NkxxkN |
Agreed
So the default CSS is created with the help palette. The role of the palette is to have a centralised place for generic values that are used in multiple places in the css. Example of the orange colour above which is injected in multiple CSS properties. The default CSS (generated with the palette - provided by the customer or not) can be overwritten by the CSS provided by the customer.
Questions: @mufassirkazi
|
@NkxxkN
|
import { SignInAndUpTheme } from "supertokens-auth-react/recipe/emailpassword"
SignUpTheme
andSignInTheme
.ThemeProvider
which can be used to overwrite the default theme based on the passed props.The text was updated successfully, but these errors were encountered: