feat: Add Automated Acceptance Test #452
Conversation
| management_account_id, | ||
| ] | ||
|
|
||
| assert expected_members == actual_members |
There was a problem hiding this comment.
I think this might fail once not all accounts in the suspended OU are not actually suspended
There was a problem hiding this comment.
The accounts should be de-registered by the cleanup script, or not?
There was a problem hiding this comment.
I double-checked. It works because we use the manual invite/accept mechanism, not the organizational guard duty feature that automatically adds all accounts. We need to make sure that the clean-up script deletes the detectors properly since it still fails from time to time, so we avoid false positives.
There was a problem hiding this comment.
Yes, I think we use the same for the backup feature. Maybe the organizations feature was not available at the time of creation?
There was a problem hiding this comment.
yes, generally aws is a bit slow in regards to integrating services on the organisational level. I'm pretty sure back then it was simply not available yet. the LZA for example uses the guard duty and security hub on org level
|
LGTM overall 👍🏻 |
peermuellerxw
had a problem deploying
to
pipeline02
GitHub Actions
Failure
peermuellerxw
changed the title
peermuellerxw
temporarily deployed
to
pipeline02
GitHub Actions
Inactive
peermuellerxw
temporarily deployed
to
pipeline02
GitHub Actions
Inactive
No description provided.